This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: Václav Zeman <vhaisman at gmail dot com>
Cc: libstdc++ at gcc dot gnu dot org, Edward Smith-Rowland <3dw4rd at verizon dot net>
Date: Sun, 10 Feb 2013 22:20:56 +0000
Subject: Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
References: <51131A02.7020104@verizon.net> <CAH6eHdQXdpYBQkVrmyHy1H5R3zNo43UNff8FjbR6vvj4dPOw-A@mail.gmail.com> <5113BB65.2050501@verizon.net> <5117F0FC.2060709@gmail.com> <CAH6eHdSe9iP7YO9-e=cwRLPGO2ax_085-AS1Unto0Bbm6OoWSA@mail.gmail.com>

On 10 February 2013 21:10, Jonathan Wakely wrote:
> On 10 February 2013 19:11, Václav Zeman wrote:
>> I believe that this patch is breaking my log4cplus builds with GCC 4.8.
>> Is this patch not missing linker exports file change that would actually
>> export the newly added operator bool()?
>
> No, because the function is not instantiated in the library, it's
> inline, so there's nothing to export.

Sorry, Paolo's pointed out to me that it is indeed broken, because we
have use 'extern template' and explicitly instantiate
basic_ostream<char> in the library.

References:
- [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Ed Smith-Rowland
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Jonathan Wakely
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Ed Smith-Rowland
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: VÃclav Zeman
- Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]