This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] basic_filebuf: 45628 + non-modal I/O

Hi,

two quick comments:
- If, while working on these issues, you figure out some rather uncontroversial changes, can you please split them out to separate patches? (eg, I noticed your comment about imbue, I'm sure can be improved, at some point started growing rather wildly to quickly answer a series of PRs submitted by Petur)
- Remember to *always* say on which machine you tested! I didn't know you are developing on Darwin and there we don't support named locales, thus testing is much weaker!

Thanks,
Paolo
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]