This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Run V3 tests on installed compiler


Benjamin Kosnik wrote:
Too late.


How rude. I expected a bit more from you.

I'm sorry to have offended you, but I think you're overreacting. I'm a maintainer with GWP and I made a change to our DejaGNU test harness, which is an area with which I am very familiar. If I'd been making non-trivial changes to the library proper (changing iostreams to do some clever new thing, say), I'd definitely have consulted!


Is it your position that you want 24 hours to review every change to anything within the libstdc++-v3 subdirectory? That's would be a unique requirement, but if you and the other five V3 maintainers think it's necessary, then I think that should be respected. If you decide to do that, would you please update http://gcc.gnu.org/cvswrite.html to indicate that V3 has this rule?

Do you wish that I revert the patch at this point?

In the future, please as a matter of professional courtesy give us 24 hrs to comment.

This patch, like the one on which it was based by Geoff Keating, has
some good ideas but fails to deal with current testing practices.  More in a bit.

I'll look forward to your comments.


(FWIW, this patch wasn't really "based" on Geoff's, in that I started from scratch. Geoff and I did discover many of the issues and come up with similar solutions.)

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]