This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: TR1 unordered associative containers

From: Joe Buck <Joe dot Buck at synopsys dot COM>
To: Chris Jefferson <caj at cs dot york dot ac dot uk>
Cc: Matt Austern <austern at apple dot com>,libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc mailing list <gcc at gcc dot gnu dot org>
Date: Thu, 17 Feb 2005 16:29:24 -0800
Subject: Re: PATCH: TR1 unordered associative containers
References: <39885D64-813E-11D9-BB2D-000A95AA5E5E@apple.com> <20050218001839.GA18919@synopsys.com> <42153570.6000101@cs.york.ac.uk>

Joe Buck wrote:
> >A namespace purity nitpick:
> >
> >You define a macro named tr1_hashtable_define_trivial_hash.  Shouldn't
> >that be __tr1_hashtable_define_trivial_hash or something similar?

On Fri, Feb 18, 2005 at 12:23:12AM +0000, Chris Jefferson wrote:
> Having just read through, everything seems very reasonable to me, but I 
> think there is a general need a liberal splattering of __ here, there 
> and everywhere :) It would be very nice if we could stop having to 
> prefix everything with __ and just pop it into a namespace instead, but 
> fixing that is perhaps something for another day :)

I only singled out the macro, because namespaces have no effect on macros.

References:
- PATCH: TR1 unordered associative containers
  - From: Matt Austern
- Re: PATCH: TR1 unordered associative containers
  - From: Joe Buck
- Re: PATCH: TR1 unordered associative containers
  - From: Chris Jefferson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]