This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: PATCH: TR1 unordered associative containers
- From: Chris Jefferson <caj at cs dot york dot ac dot uk>
- To: Joe Buck <Joe dot Buck at synopsys dot COM>
- Cc: Matt Austern <austern at apple dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc mailing list <gcc at gcc dot gnu dot org>
- Date: Fri, 18 Feb 2005 00:23:12 +0000
- Subject: Re: PATCH: TR1 unordered associative containers
- References: <39885D64-813E-11D9-BB2D-000A95AA5E5E@apple.com> <20050218001839.GA18919@synopsys.com>
Joe Buck wrote:
On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote:
I'm sure there are still lots of horrible bugs, which will only be
found with a more complete test suite. But the core functionality
works, and at this point I think it'll improve faster in the CVS server
than sitting on my hard disk.
OK to commit to mainline?
A namespace purity nitpick:
You define a macro named tr1_hashtable_define_trivial_hash. Shouldn't
that be __tr1_hashtable_define_trivial_hash or something similar?
Having just read through, everything seems very reasonable to me, but I
think there is a general need a liberal splattering of __ here, there
and everywhere :) It would be very nice if we could stop having to
prefix everything with __ and just pop it into a namespace instead, but
fixing that is perhaps something for another day :)
Chris