This is the mail archive of the mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: please stop messing with the indentation

On Wed, Aug 07, 2002 at 06:46:30PM -0700, Benjamin Kosnik wrote:
> > I find the un-indented version pretty much unreadable.  I contributed
> > a component that was original in the global namespace, and latter
> > namespaced without the indentation.  I guet always confused as when
> > I'm in the namespace or not -- my editor also.  So, IMHO, the
> > un-indented version is no no for me.
> FWIW, I also like the indentation. I think the namespace indentation
> goes with the class indentation to clearly show scope. This is one of
> the main reasons I'm so tempted to format the libsupc++ code. Call me
> crazy....

Enh, we knew you were crazy before this already.  :-)

I don't feel very strongly about the namespace indentation.  And I do
agree that libsupc++ should also be redone.

> Phil, note that bits/stl_vector.h also has other issues besides the
> namespace issue. There seems to be other instances of C++STYLE avoidance
> to get the braces in column zero. Can you provide a bit more detail as
> to why this is important for you? 

This is funny, because everything /other/ than the namespace indentation
I tried to do according to C++STYLE.  So violations like the one you posted
are definitely wrong.

I'm willing to yield on the namespace thing; editors and tools which
can't handle column-zero braces are not required tools in the first place.
I'll re-indent them as soon as I'm up and running again.  (I'm moving my
development from one machine to another, and it's amazing how entrenched
all my scripts and crap had become...)  This week probably.


I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
                                                  - Edsger Djkstra, 1930-2002

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]