Re: [PATCH] Normalization of Java sources

[Dr Andrew John Hughes <ahughes at redhat dot com>]

On 14:40 Tue 11 Jan     , Andrew Haley wrote:
> On 01/11/2011 02:33 PM, Dr Andrew John Hughes wrote:
> 
> > I have a filter in emacs for tabs to keep the OpenJDK files in
> > order, which was causing additional whitespace diffs when editing
> > Classpath files.  To avoid having to turn it on and off all the
> > time, I normalised Classpath as there didn't seem to be anything in
> > the rules against it and no existing consistency in the sources.
> 
> I use emacs too, and indent-tabs-mode = nil only affects code that you
> actually touch.

That's exactly the problem.  Prior to the normalisation patch, I'd
touch a file to fix some bug and end up introducing additional
whitespace changes.

Normalising the codebase was a solution to having to split out
whitespace changes in such cases by addressing them all in one batch.
There's an obvious alternative in that you turn the emacs setting
on/off as you switch between codebases, but in reality you tend to
only remember about it when you get the diff with the whitespace
changes.

> 
> > In retrospect, it probably wasn't the best idea, but we should at least
> > match gcj's Classpath sources to Classpath now, so that future merges
> > aren't obliterated by whitespace diffs.
> 
> Yes, it's too late to change now.
> 
> Andrew.

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8