Re: [PATCH] Normalization of Java sources

[Mark Wielaard <mark at klomp dot org>]

On Tue, 2011-01-11 at 09:57 +0000, Andrew Haley wrote:
> On 01/10/2011 10:43 PM, Dr Andrew John Hughes wrote:
> > Back in June last year, I normalised the whitespace in the GNU Classpath
> > Java sources using a script written by Kelly O'Hair (attached) which was originally
> > used for the OpenJDK sources.  To quote the script, it:
> >
> > # Parses java files:
> > #   1. Removes from the end of lines spaces and TABs
> > #   2. Replaces TABs by spaces
> > #   3. Replaces all NewLine separators by Unix NewLine separators
> > #   4. Makes one and only one empty line at the end of each file
> >
> > The attached patch does the same for gcj trunk, bringing the GNU Classpath
> > and libjava gcj sources back in sync.  It also extends the normalization to the
> > gcj-local sources in libjava.
> >
> 
> > 	Normalise whitespace.
> >
> > Following this patch's approval, I'll merge the remaining Classpath changes
> > over.
> >
> > Ok for trunk?
> 
> I'd rather not, given the limited utility of the change and the fact
> that it messes up the diffs, making life difficult for the maintenance
> programmer.
> 
> However, we're going to get the changes anyway the next time there's
> a merge from Classpath, and we want to minimize divergence with that
> code base, so it's OK to do this on the Classpath source.

I had missed this was done to the GNU Classpath sources. Which shows how
little I hack these days :{ If I had noticed I would also have suggested
not doing this for the same reasons Andrew gives. Sorry I missed it. But
yeah, if it keeps libgcj and classpath in sync then please do it to
both, but only for those files really necessary. If you do please do
update the hacking guides. This change makes us use even more non-gnu
standard coding style (2 and I think 4 seems not according to the
current style):
http://www.gnu.org/software/classpath/docs/cp-hacking.html#SEC10
Files under classpath/doc/cp-hacking.texinfo

Thanks,

Mark