Re: [RFA] JDWP implement VMVM::getFrame

[Kyle Galloway <kgallowa at redhat dot com>]

Tom Tromey wrote:
> > > > > > "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
> > > > > >             
>
> Kyle> This patch implements the JDWP method getFrame from
> Kyle> natVMVirtualMachine.cc.
>
> Looks good.  Just one nit...
>
> Kyle> +    loc = new Location (meth, static_cast<jlong> (info.location));
>
> By my reading, info.location is a jlong, so we shouldn't need this
> cast.
>
> Assuming I'm right, this is ok with that change.
> And if I'm wrong, it is ok without it :)
>   
You are correct, I have removed the cast and committed.

- Kyle