This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] JDWP implement VMVM::getFrame

>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:

Kyle> This patch implements the JDWP method getFrame from
Kyle> natVMVirtualMachine.cc.

Looks good.  Just one nit...

Kyle> +    loc = new Location (meth, static_cast<jlong> (info.location));

By my reading, info.location is a jlong, so we shouldn't need this
cast.

Assuming I'm right, this is ok with that change.
And if I'm wrong, it is ok without it :)

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]