Re: retracting my retraction [patch included]

[Andrew Haley <aph at redhat dot com>]

Adam Megacz writes:
 > 
 > See below.
 > 
 > Adam Megacz <megacz@cs.berkeley.edu> writes:
 > > Mohan Embar <gnustuff@thisiscool.com> writes:
 > >> Hi Adam,
 > >>
 > >>>Andrew Haley <aph@redhat.com> writes:
 > >>>>  > -         GCJ="${target_noncanonical}-gcj"
 > >>>>  > +         GCJ="$built_gcc_dir/${target_noncanonical}-gcj"
 > >>>
 > >>>> This change shouldn't be necessary.  I think it's related to a bug
 > >>>> that tromey is working on.
 > >>>
 > >>>Currently this problem is still preventing cross-compiles, and this
 > >>>fix still works.  Please let me know if there is some other way in
 > >>>which I should be fixing this.
 > >>
 > >> Can you elaborate more on why you think this is needed? My MinGW ecj
 > >> build worked fine without this,
 > >
 > > Sorry, when going back through my changes I confused a new change with
 > > this one (which is no longer needed).  See next posting.  Sorry for
 > > the confusion.
 > 
 > Nope, I still need this one too -- or at least something very close to
 > it:
 > 
 >   Index: configure.ac
 >   ===================================================================
 >   --- configure.ac        (revision 120101)
 >   +++ configure.ac        (working copy)
 >   @@ -323,9 +323,9 @@
 >             GCC_UNWIND_INCLUDE=
 >             GCJ="${target_noncanonical}-gcj"
 >          else
 >   -         GCJ="${target_noncanonical}-gcj -B`${PWDCMD-pwd}`/"
 >   +         GCJ="$built_gcc_dir/gcj -B$built_gcc_dir/"
 >          fi
 >   
 > Specifically, without this patch the build process attempts to invoke
 > i386-apple-darwin-gcj (in my case), which does not exist until "make
 > install" happens (and even then, it winds up in the install directory,
 > not accessible to the build).
 > 
 > May I commit this patch?

Yes.

 > 
 >   ...
 >   i386-apple-darwin-gcj -B/tmp/odc/gcc-build/i386-apple-darwin/libjava/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/tmp/odc/gcc-build/i386-apple-darwin/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c ../../../gcc/libjava/java/lang/Class.java -fno-common -o java/lang/.libs/Class.o
 >   ./libtool: line 1: i386-apple-darwin-gcj: command not found
 >   make[4]: *** [java/lang/Class.lo] Error 1
 >   make[4]: Leaving directory `/tmp/odc/gcc-build/i386-apple-darwin/libjava'
 >   make[3]: *** [all-recursive] Error 1
 >   make[3]: Leaving directory `/tmp/odc/gcc-build/i386-apple-darwin/libjava'
 >   make[2]: *** [all-target-libjava] Error 2
 >   make[2]: Leaving directory `/tmp/odc/gcc-build'
 >   make[1]: *** [all] Error 2
 >   make[1]: Leaving directory `/tmp/odc/gcc-build'
 >   make: *** [/tmp/odc/prefix/bin/i386-apple-darwin-gcc] Error 2
 > 
 > Mohan, when you did your Canadian crossbuild, did this line work for
 > you?  If so, where was it getting the i686-pc-minwg32-gcj from?

I was wondering that too.

Andrew.