This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: RFC: Untested Win32 InetAddress tweak
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Marco Trudel <mtrudel at gmx dot ch>
- Cc: Gary Benson <gbenson at redhat dot com>, java-patches at gcc dot gnu dot org
- Date: Sun, 01 Oct 2006 13:00:11 -0500
- Subject: Re: RFC: Untested Win32 InetAddress tweak
- Reply-to: gnustuff at thisiscool dot com
Hi All,
>> The last part of java.net.InetAddress.lookup (a native method) is the
>> same in both Posix and Win32 variants except for a security check that
>> was removed from the Posix variant in August 2004. The attached patch
>> removes this check from the Win32, synchronising the two.
>>
>> I don't have the ability to test this, so could someone try it for me?
>> Alternatively, is this a trivial enough change to just commit blind?
>
>Something must have went wrong. java/net/InetAddress.java was changed
>according this patch, java/net/natInetAddressWin32.cc has not. This
>leads to an error on compilation. Please commit the rest as well...
>
>Here's the link to the trunk head, you can see that the code is still there:
>http://gcc.gnu.org/viewcvs/trunk/libjava/java/net/natInetAddressWin32.cc?view=markup
I agree with Marco. Although I understand that Gary probably can't
commit the rest without approval, I can also confirm that current SVN HEAD
breaks for Win32 without Gary's patch + my minor address-of corrections.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/