This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: rewrite File.toCanonicalPath() for GNU/Posix systems


Hi all,

In order for FilePermission checks to work properly it is necessary to
convert all paths to canonical form before comparing them.  I recently
fixed this in Classpath, but the fix relies on File.toCanonicalPath()
handling symbolic links as other JVMs.  GCJ's current implementation
has a number of drawbacks, which this patch fixes.

The diff of the method itself is not particularly legible, so I've
attached a copy of the new method as well.

Cheers,
Gary

2006-04-03  Gary Benson  <gbenson@redhat.com>

	Partial fix for PR classpath/24895
	java/io/natFilePosix.cc (getCanonicalPath): Rewrite.
	java/io/File.java (getCanonicalPath): Javadoc fix.
	configure.ac: Replace check for realpath with checks for
	lstat and readlink.
	configure: Rebuilt.
	include/config.h.in: Likewise.

Attachment: patch
Description: Text document

Attachment: canon.cc
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]