Re: [cp-patches] Patch: FYI: speed up split-for-gcj

[Andrew Haley <aph at redhat dot com>]

Mark Wielaard writes:
 > Hi Tom,
 > 
 > On Sat, 2006-04-01 at 12:11 -0700, Tom Tromey wrote:
 > > >>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
 > > 
 > > Mark> Unfortunately it seems to trigger some gcj bug with the svn trunk
 > > Mark> development version on builder (see below). I checked against 4.0.3 and
 > > Mark> 4.1 and they both seem fine. I am not 100% sure it is caused by this
 > > Mark> patch (still building a 4.2 version myself, but I need to go for today,
 > > Mark> so might not be able to check definitely till Monday).
 > > 
 > > I think this crash predates the split-for-gcj change by several hours.
 > 
 > Seems you are right. I tested against gcc/java revisions 112102, 112499
 > and 112540 which seem to compile things fine. Revision 112574 seems to
 > cause the failure, so it was probably this patch:
 > 
 > 2006-03-30  Andrew Haley  <aph@redhat.com>
 > 
 >         PR java/26858
 >         * lang.c (java_attribute_table): New.
 >         (LANG_HOOKS_ATTRIBUTE_TABLE): Define.
 >         * expr.c (build_field_ref): Add a null pointer check for all
 >         fields of offset > 4k.  Don't do so for accesses via the this
 >         pointer, which we know can never be null.
 >         * class.c (build_java_method_type): Mark arg 1 of all nonstatic
 >         methods nonnull.
 > 
 > After generating the list files in classpath/lib you can trigger the
 > compile error by:

This one is unrepro for me on x86_64.  This is 32-bit x86, right?

Andrew.