This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] java.io.BufferedInputStream.skip(long)...


Am Mittwoch, 17. November 2004 18:15 schrieb David Daney:
> Michael Koch wrote:
> > Am Dienstag, 16. November 2004 23:14 schrieb David Daney:
> >>InputStream.skip(long) should (i.e. is required to) return the
> >>number of bytes skipped.
> >>
> >>BufferedInputStream was returning -1 on EOF in violation of the
> >>specification.
> >>
> >>This patch corrects the problem by returning 0 (zero) when skip()
> >>is called at EOF.
> >>
> >>Tested on i686-pc-linux-gnu with make check in libjava with no
> >>regressions.
> >>
> >>OK to commit?
> >
> > Wouldn't it be better to put the testcase into Mauve instead of
> > keeping it secret in libgcj ?
>
> Perhaps it would, I will look into it.

If you want I can do the mauve part for you. Just tell me.


Michael
-- 
Homepage: http://www.worldforge.org/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]