This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] java.io.BufferedInputStream.skip(long)...
- From: Michael Koch <konqueror at gmx dot de>
- To: java-patches at gcc dot gnu dot org
- Cc: David Daney <ddaney at avtrex dot com>
- Date: Wed, 17 Nov 2004 08:22:53 +0100
- Subject: Re: [Patch] java.io.BufferedInputStream.skip(long)...
- References: <419A7BC3.5010905@avtrex.com>
Am Dienstag, 16. November 2004 23:14 schrieb David Daney:
> InputStream.skip(long) should (i.e. is required to) return the
> number of bytes skipped.
>
> BufferedInputStream was returning -1 on EOF in violation of the
> specification.
>
> This patch corrects the problem by returning 0 (zero) when skip()
> is called at EOF.
>
> Tested on i686-pc-linux-gnu with make check in libjava with no
> regressions.
>
> OK to commit?
Wouldn't it be better to put the testcase into Mauve instead of
keeping it secret in libgcj ?
Michael
--
Homepage: http://www.worldforge.org/