This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Committed: Fix C99:ism (declaration after statement) in java FE.
Steven Bosscher <stevenb@suse.de> writes:
> On Sunday 17 October 2004 12:59, Hans-Peter Nilsson wrote:
>> On Sat, 16 Oct 2004, Kaveh R. Ghazi wrote:
>> > > Hope to look into adding -Wdeclaration-after-statement for all
>> > > front-ends @WERROR@ settings (stage2 or where supported).
>> >
>> > No need for a new flag, just add -pedantic like the other FEs do.
>> > (Haven't tried it myself, probably requires cleaning other fallout.)
>>
>> Hmm, looks like you're right. Tom Tromey mentioned on IRC that
>> he'd like more warnings enabled, so it seems this would be the
>> way to go. Maybe I'll do it.
>
> I've just done it. It's still bootstrapping on x86_64-suse-linux-gnu
> but I'm not expecting any problems (it's well into libjava now).
>
> OK if it completes bootstrapping and testing?
...
> ! # Use strict warnings for this front end.
> ! java-warn = $(STRICT_WARN) $(WERROR)
Don't put $(WERROR) here, it is handled separately.
> ! to (void *) so that either way it is quietly accepted.
> ! FIXME: scandir is not in POSIX. */
> dent->num_files = scandir (filename, &dent->files,
> (void *) java_or_class_file,
> alphasort);
Is the diagnostic for an implicit declaration? If so, you really
ought to investigate where the prototype is supposed to be coming
from, and get it declared. You don't have to fix this in this patch
though.
Otherwise OK.
zw