This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] image processing fix for BE machine

From: Andreas Tobler <toa at pop dot agri dot ch>
To: Thomas Fitzsimmons <fitzsim at redhat dot com>
Cc: Java Patches <java-patches at gcc dot gnu dot org>, Mark Wielaard <mark at klomp dot org>
Date: Wed, 22 Sep 2004 22:16:17 +0200
Subject: Re: [patch] image processing fix for BE machine
References: <414EEBB3.2080909@pop.agri.ch> <1095880888.4851.75.camel@tortoise.toronto.redhat.com>

Thomas Fitzsimmons wrote:

On Mon, 2004-09-20 at 10:39, Andreas Tobler wrote:

Hi Little endian world,

it seems that the whole swing development happens on LE machines ;)

The attached patch corrects pixel handling for BE machines. Tested here on ppc-darwin8.
This looks good, except that we should define the SWAPU32 macro in the
common header, gtkpeer.h.  With that change, this can go in.

Fine, thanks. Is gtkpeer.h automagically included by GdkGraphics2D.c or do I have to include it there too? I thought to place it in both, gtkpeer.h and gtkcairopeer.h to have them in different places.

But if it is ok to include gtkpeer.h in GdkGraphics2D.c then I do so.

again, thanks for review.

Andreas

Follow-Ups:
- Re: [patch] image processing fix for BE machine
  - From: Thomas Fitzsimmons

References:
- [patch] image processing fix for BE machine
  - From: Andreas Tobler
- Re: [patch] image processing fix for BE machine
  - From: Thomas Fitzsimmons

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]