This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: RFA: fix PR java/16789
- From: Michael Koch <konqueror at gmx dot de>
- To: tromey at redhat dot com
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Andrew Haley <aph at redhat dot com>
- Date: Wed, 22 Sep 2004 08:36:48 +0200
- Subject: Re: Patch: RFA: fix PR java/16789
- References: <m3zn3j5jwc.fsf@localhost.localdomain>
On Wednesday 22 September 2004 00:36, Tom Tromey wrote:
> This patch fixes PR 16789.
>
> There are two parts to this bug.
>
> First, we generated incorrect bytecode for something like
> staticMethod().staticMethod() (which is valid but weird). This was
> compiled to <compound_expr <call> <call>>, and we weren't setting
> CAN_COMPLETE_NORMALLY on the first call -- so jcf-write would omit
> the second call.
>
> Second, this construct was causing a crash in
> force_evaluation_order. I believe the correct fix is to move the
> check for a no-argument call below the code that unwraps the
> COMPOUND_EXPR.
>
> Michael, I CC'd you since I think this might fix the ICE we were
> debugging in irc yesterday. It is worth a try anyway.
Tested on my i686-pc-linux-gnu and this patch makes it possible to
build pristine checkstyle 3.4.
Thanks for the fast fix.
Michael