Re: [BC] Patch: FYI: Class preparation rewrite

[Bryce McKinlay <mckinlay at redhat dot com>]

Tom Tromey wrote:

> I'm checking this in on the binary compatibility branch.
>
> This is a reorganization of class preparation.  In particular most of
> the interpreter #ifdefs were removed; execution-engine-specific code
> is now encapsulated in an ad hoc class.  Preparation is now
> consolidated in resolve.cc, methods were renamed to have less
> confusing names, and the interaction between preparation and
> initialization in Class.initializeClass is now more understandable
> (IMO).
>
> I've tested this by running the test suite, including Mauve and Jacks.
> The results there seem reasonable.  Also I compiled Eclipse 2.x to
> native with this, and it works fine with various mixes of interpreted
> and -findirect-dispatch -compiled code
Cool. I'm not sure about putting all the ABI linking code into something 
called _Jv_Resolver, though, and I always thought of resolve.cc as an 
interpreter specific class. Would _Jv_Linker be a better name? My idea 
was to move this stuff (ie the code to build the various indirect 
dispatch tables) to something called link.cc. Its doing a lot more than 
just resolving stuff :)

There are a few details of the _Jv_ExecutionEngine I'm not sure about - 
it seems like a bit too much is exposed publically by this interface, 
but I guess we can work that out more as we go along...

Bryce