This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch: javax.swing.JComponent
- From: Michael Koch <konqueror at gmx dot de>
- To: java-patches at gcc dot gnu dot org
- Date: Mon, 13 Sep 2004 14:37:27 +0200
- Subject: Patch: javax.swing.JComponent
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi list,
I just commited the attached patch to make javax.swing.JComponent fire
PropertyChangeEvents when it should.
Michael
2004-09-13 Michael Koch <konqueror@gmx.de>
* javax/swing/JComponent.java
(JComponent): Added javadoc comment.
(setBorder): Fire property change eventr.
(setEnabled): Likewise.
(setMaximumSize): Likewise.
(setMinimumSize): Likewise.
(setPreferredSize): Likewise.
(setOpaque): Likewise.
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFBRZSLWSOgCCdjSDsRAlONAJwL8evD3+E8Qx8SfnjtA9EkGfC01gCfWVHC
iOuXtMYK2YMEj0W01aJThyo=
=dvT3
-----END PGP SIGNATURE-----
Index: javax/swing/JComponent.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/javax/swing/JComponent.java,v
retrieving revision 1.7.2.17
diff -u -r1.7.2.17 JComponent.java
--- javax/swing/JComponent.java 27 Aug 2004 15:45:36 -0000 1.7.2.17
+++ javax/swing/JComponent.java 13 Sep 2004 12:25:47 -0000
@@ -379,6 +379,9 @@
public static final int WHEN_IN_FOCUSED_WINDOW = 2;
+ /**
+ * Creates a new <code>JComponent</code> instance.
+ */
public JComponent()
{
super();
@@ -796,13 +799,15 @@
* Set the value of the {@link #border} property, revalidate
* and repaint this component.
*
- * @param border The new value of the property
+ * @param newBorder The new value of the property
*
* @see #getBorder
*/
- public void setBorder(Border border)
+ public void setBorder(Border newBorder)
{
- this.border = border;
+ Border oldBorder = border;
+ border = newBorder;
+ firePropertyChange("border", oldBorder, newBorder);
revalidate();
repaint();
}
@@ -1907,11 +1912,13 @@
* Set the value of the {@link #enabled} property, revalidate
* and repaint this component.
*
- * @param e The new value of the property
+ * @param enable The new value of the property
*/
- public void setEnabled(boolean e)
+ public void setEnabled(boolean enable)
{
- super.setEnabled(e);
+ boolean oldEnabled = isEnabled();
+ super.setEnabled(enable);
+ firePropertyChange("enabeld", oldEnabled, enable);
revalidate();
repaint();
}
@@ -1963,7 +1970,9 @@
*/
public void setMaximumSize(Dimension max)
{
+ Dimension oldMaximumSize = maximumSize;
maximumSize = max;
+ firePropertyChange("maximumSize", oldMaximumSize, maximumSize);
revalidate();
repaint();
}
@@ -1976,7 +1985,9 @@
*/
public void setMinimumSize(Dimension min)
{
+ Dimension oldMinimumSize = minimumSize;
minimumSize = min;
+ firePropertyChange("minimumSize", oldMinimumSize, minimumSize);
revalidate();
repaint();
}
@@ -1989,7 +2000,9 @@
*/
public void setPreferredSize(Dimension pref)
{
+ Dimension oldPreferredSize = preferredSize;
preferredSize = pref;
+ firePropertyChange("preferredSize", oldPreferredSize, preferredSize);
}
/**
@@ -2025,7 +2038,9 @@
*/
public void setOpaque(boolean isOpaque)
{
+ boolean oldOpaque = opaque;
opaque = isOpaque;
+ firePropertyChange("opaque", oldOpaque, opaque);
revalidate();
repaint();
}