This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Conditionally reintroduce config.h to ggc-none.c


Hi Andrew,

> > > It reintroduces #include "config.h" based on the macro
> > > GENERATOR_FILE. It's needed for the second Java-specific patch which
> > > needs a host-specific ggc-none.o for gcjh and jcf-dump when doing a
> > > cross build. The post-patch behavior should be 100% identical
> > > (knocking on simulated wood cabinet) to the prepatch behavior for
> > > the top-level build of this file because -DGENERATOR_FILE is always
> > > defined when building the top-level ggc-none.o.
> > 
> > This looks good to me; if Andrew is happy I'll approve the
> > language-independent bits.
>
>OK.

Sorry to be anal, but I just wanted to double-check that your
"OK" was for this:

http://gcc.gnu.org/ml/gcc-patches/2004-09/msg00587.html

...and not the patch you replied to, which was this:

http://gcc.gnu.org/ml/gcc-patches/2004-09/msg00586.html

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]