This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH]: Conditionally reintroduce config.h to ggc-none.c
- From: Zack Weinberg <zack at codesourcery dot com>
- To: gnustuff at thisiscool dot com
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, Andrew Haley <aph at redhat dot com>
- Date: Mon, 06 Sep 2004 21:57:24 -0700
- Subject: Re: [PATCH]: Conditionally reintroduce config.h to ggc-none.c
- References: <NMUR72MAPUQD93V4XA7A50QK72L.413cdbc2@d7500>
Mohan Embar <gnustuff@thisiscool.com> writes:
> (Since this patch affects a top-level Changelog, I wasn't sure
> whether to submit it together with the Java-specific second part or
> alone as I've done here. So much to learn....)
In this case I think it would have been best not to split it.
> It reintroduces #include "config.h" based on the macro
> GENERATOR_FILE. It's needed for the second Java-specific patch which
> needs a host-specific ggc-none.o for gcjh and jcf-dump when doing a
> cross build. The post-patch behavior should be 100% identical
> (knocking on simulated wood cabinet) to the prepatch behavior for
> the top-level build of this file because -DGENERATOR_FILE is always
> defined when building the top-level ggc-none.o.
This looks good to me; if Andrew is happy I'll approve the
language-independent bits.
zw