This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: configure.in cleanup

Michael Koch wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi list,


I wrote the attached patch to cleanup configure.in. Bootstrapped on i686-pc-linux-gnu.

Ok to commit to trunk ?



OK, except for...

-AC_OUTPUT(Makefile libgcj.pc libgcj.spec libgcj-test.spec gnu/classpath/Configuration.java gcj/Makefile include/Makefile testsuite/Makefile,
+AC_CONFIG_FILES(
+Makefile
+gcj/Makefile
+include/Makefile
+testsuite/Makefile
+libgcj.pc
+libgcj.spec
+libgcj-test.spec
+gnu/classpath/Configuration.java
+)


Is the 1-per-line approach really better? It might make for cleaner diffs, but I think it'd be easier to read if we had a few files per line, although wrapped at 80 chars... what do you think?

BTW: When posting configure/Makefile changes, there is no need to post diffs of the generated files.

Thanks!

Bryce

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]