This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA PATCH: Fix PosixProcess some more...

Bryce McKinlay wrote:
> David Daney wrote:
> 
> 
>>Here they are.
>>
>>Currently in make check.
>>
>>O.K. to commit if no regressions?
>> 
>>
> 
> Just one thing I noticed...
> 
> 
>> {
>>   using namespace java::lang;
>> 
>>!   sigset_t mask, new_mask;
>>   // Wait for SIGCHLD
>>   sigemptyset (&mask);
>>!   pthread_sigmask (SIG_BLOCK, &mask, &new_mask);
>> 
>>
> 
> Isn't the sigemptyset a no-op? I think you can just do "pthread_sigmask 
> (0, NULL, &mask)" to obtain the current sigmask.

Patch committed with pthread_sigmask (0, NULL, &mask).

> 
> Patch is ok to commit, otherwise. Test case not ok for reasons mentioned 
> in previous email, though it would be nice if we did have somewhere to 
> put such tests...
> 

David Daney.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]