This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Hash synchronization (PR 16662) patch
- From: Bryce McKinlay <mckinlay at redhat dot com>
- To: "Boehm, Hans" <hans dot boehm at hp dot com>
- Cc: "'java-patches at gcc dot gnu dot org'" <java-patches at gcc dot gnu dot org>
- Date: Thu, 12 Aug 2004 16:43:24 -0400
- Subject: Re: Hash synchronization (PR 16662) patch
- References: <0C3EFB691636964BBF914AE56AE83A89502274@hplex4.hpl.hp.com>
Boehm, Hans wrote:
I checked the patch from http://gcc.gnu.org/ml/java/2004-08/msg00047.html into the trunk.
As part of this effort, I resurrected the Heap profiling patch from http://gcc.gnu.org/ml/java/2004-03/msg00222.html which is still in my tree. After some earlier discussion, I'm still confused as to whether I need permission to check this in. Could someone resolve the ambiguity by approving that patch?
Hans,
This looks pretty cool. However, I think it would be nice to avoid the
#ifdefs - ie instead of choosing the allocation function at compile time
with LIBGCJ_GC_DEBUG, it would be nicer to provide a runtime argument
that switches between the normal & debug allocation functions. Perhaps
_Jv_InitGC could set up a table of the allocation functions depending on
what value is set during runtime startup. Is this practical?
Also, regarding the duplication of _Jv_AllocObj etc - I presume there is
some hairy reason why we can't just include gc_gcj.h in libjava's
boehm-gc.h?
By the way, I'm planning to import the GC 6.3 distribution shortly.
Regards
Bryce