Re: [RFA] Patch: Fix PosixProcess / PR libgcj 11801

[David Daney <ddaney at avtrex dot com>]

Bryce McKinlay wrote:
> David Daney wrote:
> 
> 
>>Attached is a new version of the patch.  It addresses all of the issues
>>raised by Bryce (I think).
>>
>>Tested as follows:
>>
>>i686-pc-linux-gnu  (Fedora Core 1 w/ NPTL) make check in libjava with no
>>failures.
>>
>>mipsel-linux-gnu (glibc 2.2.5) make check in libjava with no regressions.
>>
>>These tests include these:
>>
>>http://gcc.gnu.org/ml/java-patches/2004-q3/msg00451.html
>>
>>6 new tests that I will commit when (and if) this patch is authorized.
>>
>>OK to commit?
>> 
>>
> 
> 
> Just one more general comment about the patch - there seems to be a lot 
> of spurious deltas in natPosixProcess.cc caused by code reformatting or 
> whitespace changes. This makes the patch difficult to read because its 
> difficult to see exactly which code was changed and which was just 
> reformatted. If you could fix that before committing it would be 
> appreciated.
> 
> Aside from that, this is OK to commit. Thank you very much for working 
> on this - its an important improvement that has been needed for quite 
> some time.
> 
> Regards
> 
> Bryce
> 

Committed with formatting changes to natPosixProcess.cc that reduce the
size of the diff.

David Daney.