This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Patch: Fix PosixProcess / PR libgcj 11801

David Daney wrote:

Is the outer try block here necessary? I think it would be better just to let the default handler for the thread handle it.


If it were not there, RuntimeExceptions would be able to terminate the
ProcessManager loop. That would prevent any Process related calls from
working. In an ideal world the code would be bug free, but I think it
is better safe than sorry.


Yeah. In the cases where exceptions should not be possible unless there are bugs in our own code, I tend to prefer just throwing them since that makes sure there is no possibility of such problems being hidden and going undetected. I think your argument is valid here too, though, so I'm ok with your decision.

Thanks

Bryce

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]