This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFT/RFC] Fix PosixProcess / PR libgcj 11801...
- From: David Daney <ddaney at avtrex dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Tue, 27 Jul 2004 18:04:10 -0700
- Subject: Re: [RFT/RFC] Fix PosixProcess / PR libgcj 11801...
- References: <4106A91F.2020607@avtrex.com> <4106C713.80102@redhat.com>
Bryce McKinlay wrote:
> David Daney wrote:
>
>
>>In this thread:
>>
>>http://gcc.gnu.org/ml/java/2004-07/msg00109.html
>>
>>Thread we discussed ways to fix PosixProcess.
>>
>>Attached is my first pass at fixing the problems. I get no testsuite
>>failures on i686-pc-linux-gnu (Fedora Core 1 w/ NPTL). And several
>>small test programs seem to work. I am also starting to test it on
>>mipsel-linux-gnu (w/ glibc-2.2.5). These are the only two posix
>>platforms I have access to.
>>
>>It seems possible that this patch could break other posix platforms, so
>>testing is needed before commiting it.
>>
>>Thoughts or Comments?
>>
>
> Oh, another thing - our test suite coverage for java.lang.Process is
> non-existent currently, as far as I can tell. Presumably you wrote some
> test code while developing this, so if you'd like to turn it into a
> mauve test, that would be fantastic (and ensure that it doesn't get
> broken again at some later time).
>
The tests mostly consist of using 'ps' and visually verifying that there
are not any zombies hanging around. Although there are some things
that can be tested without external process monitoring programs. Most
tests require external executables also.
I am not really sure how one would go about integrating something like
this into Mauve. Instead of invoking some java method, can Mauve run a
bash and/or perl script? That is really what is needed to automate testing.
David Daney.