Re: [gui][patch] various fixes to scrolling

[Bryce McKinlay <mckinlay at redhat dot com>]

Thomas Fitzsimmons wrote:

> On Sat, 2004-07-10 at 14:00, graydon hoare wrote:
>  
>
> > hi,
> >
> > I just committed this patch which fixes a few compile-with-jikes problems
> > and a variety of little incorrect calculations related to scrollpanes,
> > scrollbars, buttons, viewports, etc. the result has the scrollpanes and
> > scrollables working much more like sun's implementation.
> >
> > fwiw, I've added this rule to my supervisory makefile to make sure we're
> > catching everything jikes sees and gcj doesn't. it only takes a few extra
> > seconds on a build, and should help with classpath merging. I'd recommend
> > the other gui hackers add something similar to their environments (green
> > suggests ant+ecj, but I already had jikes+makes installed):
> >
> > check-native-with-jikes:
> > 	rm -Rf tmp-jikes-build sourcelist
> > 	mkdir tmp-jikes-build
> > 	find $(LIBJAVA) -name \*.java \
> >          | grep -v 'testsuite\|scripts\|Win32\|Ecos' >sourcelist
> > 	jikes +E -nowarn -bootclasspath $(BUILD) -d tmp-jikes-build @sourcelist
> >
> >    
>
> Can we just commit this on java-gui-branch?  Does it make sense to make
> libgcj.jar depend on this new target?
>  
It think it best to not depend on another 3rd-party tool by default, 
however it would certainly be good to have something like this available 
as an option. Something that exists already is "make JAVAC=jikes", which 
will just use jikes instead of "gcj -C" to build the class files. 
However, when I tried this with ecj it exposed a gcjh bug ... which I'm 
about to fix.

Regards

Bryce