This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [GUI] fixes for JMenuBar and JToolBar layout
- From: Olga Rodimina <rodimina at redhat dot com>
- To: Roman Kennke <roman at ontographics dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Thu, 08 Jul 2004 10:35:54 -0400
- Subject: Re: [GUI] fixes for JMenuBar and JToolBar layout
- References: <1089288335.19655.15.camel@moonlight.localdomain>
On Thu, 2004-07-08 at 08:05, Roman Kennke wrote:
> Hi list,
>
> I have put together two small fixes for JMenuBar and JToolBar. ATM these
> are laid out using GridBagLayout and BoxLayout, which is very unusual
> IMO. I have changed this to use FlowLayout in both cases, which looks
> much better.
>
> Please check and approve these patches. I am in the assignment process
> and should hopefully finish this soon. These patches are minimal, so I
> think they should go in. :)
>
I agree with you that FlowLayout would probably work better for
JMenuBar, then BoxLayout which JMenuBar is currently using. However
the reason I implemented JMenuBar to use BoxLayout because that is the
default value that java sun is using.
>From Java Swing O'Reilly, by Robert Eckstein, Marc Loy & Dave Wood,
Table 14-3. JMenuBar properties.
http://www.oreilly.com/catalog/jswing2/chapter/ch14.html#24250
The question is if we are allowed to use different default values for
the component's properties in our implementation. My opinion was that we
aren't allowed, but I could be wrong.
Regards,
Olga.