This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [gui][PATCH] some peer fixes
On Thu, 2004-06-24 at 14:21, Thomas Fitzsimmons wrote:
> On Thu, 2004-06-24 at 13:58, Michael Koch wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Am Mittwoch, 23. Juni 2004 05:51 schrieb Thomas Fitzsimmons:
> > > Hi,
> > >
> > > I committed this patch to java-gui-branch. It simplifies the
> > > GtkComponentPeer and GtkWindowPeer classes.
> > >
> > > Tom
> > >
> > > 2004-06-22 Thomas Fitzsimmons <fitzsim@redhat.com>
> > >
> > > * gnu/java/awt/peer/gtk/GtkComponentPeer.java,
> > > jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
> > > (GtkComponentPeer): Remove temporary try/catch block.
> > > (setVisible): Call show and hide.
> > > (show): Make native.
> > > (hide): Likewise.
> > > (getArgs): Don't add "visible" argument.
> > > * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c
> > > (property_notify_predicate): Return Bool instead of int.
> > > (find_layout): New function.
> > > (connectJObject): Call find_layout.
> > > (connectSignals): Likewise.
> > > (moveLayout): Likewise.
> > > (gtkLayoutSetVisible): Likewise.
> >
> > This patch severly broke AWT/Swing. I reverted it locally and
> > AWT/Swing was more usable again, not totally. I vote for reverting
> > this patch for now until the issues are solved.
> >
>
> Yes, please do. I tested this patch in the presence of other
> work-in-progress patches, then submitted it separately. It appears I
> should have tested it on its own. Sorry!
>
> Tom
I'll commit the reverted patch. I have another patch I need to commit
soon, and I need to get this one out of the way first.
Cheers,
-David Jee