Re: Patch: ZipFile.getInputStream shouldn't throw NoSuchElement.

[Anthony Green <green at redhat dot com>]

On Fri, 2004-06-25 at 08:49, Mark Wielaard wrote:
> > Ok, I checked this one in.
> > [...]
> > // Copyright (C) 2003 Free Software Foundation
> > // Contributed by Mark Wielaard (mark@klomp.org)
> 
> Hey! I appreciate you wanting to give me lots of credit, but in this
> case... :)

I'll fix this cut'n'paste error :-)

> So lets go for what Anthony proposes. Return null and document it.

I've already checked a patch into libgcj with this comment:

   * This implementation returns null if the requested entry does not
   * exist.  This decision is not obviously correct, however, it does
   * appear to mirror Sun's implementation, and it is consistant with
   * their javadoc.  On the other hand, the old JCL book, 2nd Edition,
   * claims that this should return a "non-null ZIP entry".  We have
   * chosen for now ignore the old book, as modern versions of Ant (an
   * important application) depend on this behaviour.  See discussion
   * in this thread:
   * http://gcc.gnu.org/ml/java-patches/2004-q2/msg00602.html

(oops - spelled "consistent" wrong)

> Saw that the bug report Anthony reported against the Sun JDK docs was
> just closed. Sigh.

I don't think they read it carefully.  I'll follow up.

AG

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.