This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: java.text collators
- From: Michael Koch <konqueror at gmx dot de>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org, tromey at redhat dot com
- Date: Tue, 1 Jun 2004 00:18:07 +0200
- Subject: Re: Patch: java.text collators
- References: <200405311053.25118.konqueror@gmx.de> <40BBABC1.6000204@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 1. Juni 2004 00:03 schrieb Bryce McKinlay:
> Michael Koch wrote:
> >I merged the attached patch locally from GNU classpath and saw
> > that all mauve testcases for java.text.CollationElementIterator
> > and java.text.RuleBaseCollator pass now. That's really amazing
> > work by Guilhem Lavaux and gives us the possibility to merge
> > future fixes to this code easily. This also removes the xfailed
> > tests.
>
> Wow - great stuff!
>
> >Okay to commit to trunk ?
>
> OK, with a few comments:
> >+ Vector v = new Vector();
> >+ Vector vi = new Vector();
> >+
> >+ // Build element collection ordered as they come in "text".
> >+ while (idx < work_text.length())
>
> Could ArrayList be used here?
>
> >+ key = work_text.substring (idx, idx+p);
> >+ object = collator.prefix_tree.get (key);
>
> There are a few formatting errors here. These should ideally be
> cleaned up so that there isn't a space between the method name and
> arguments/braces.
Commited now as is. The suggested fixes will be addressed in an
upcoming patch.
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAu68iWSOgCCdjSDsRAvm2AJ91WgX0mxjFVFIuYM8bPMLGnXuKFgCbB6Zc
WHtw83PpXk9t0qWx8PQPM+s=
=iRn5
-----END PGP SIGNATURE-----