Re: Patch: java.text collators

[Bryce McKinlay <mckinlay at redhat dot com>]

Michael Koch wrote:

> I merged the attached patch locally from GNU classpath and saw that 
> all mauve testcases for java.text.CollationElementIterator and 
> java.text.RuleBaseCollator pass now. That's really amazing work by 
> Guilhem Lavaux and gives us the possibility to merge future fixes to 
> this code easily. This also removes the xfailed tests.
>  

Wow - great stuff!

> Okay to commit to trunk ?
>  

OK, with a few comments:

> +    Vector v = new Vector();
> +    Vector vi = new Vector();
> +
> +    // Build element collection ordered as they come in "text".
> +    while (idx < work_text.length())
>  

Could ArrayList be used here?

> +	    key = work_text.substring (idx, idx+p);
> +	    object = collator.prefix_tree.get (key);
>  
There are a few formatting errors here. These should ideally be cleaned 
up so that there isn't a space between the method name and arguments/braces.

Regards

Bryce