Re: [patch] SimpleTimeZone take 2

[Michael Koch <konqueror at gmx dot de>]

Am Freitag, 7. Mai 2004 15:46 schrieb Andrew Haley:
> Michael Koch writes:
>  > Am Freitag, 7. Mai 2004 15:30 schrieb Jerry Quinn:
>  > > Michael Koch writes:
>  > >  > Does the mauve test breaky compilation of mauve ? If yes we
>  > >  > can exclude this test in mauve-libgcj file. Its always good
>  > >  > to have the tests in mauve.
>  > >
>  > > It compiles fine.  But the test has failures since the library
>  > > isn't correct.  I'm asking because usually tests don't get
>  > > checked into the gcc testsuite while gcc is still broken.
>  > >
>  > > Maybe someone :-) should write a page describing checkin rules
>  > > for mauve, such as gcc-style changelog, make sure mauve
>  > > compiles, tests that fail are ok, etc...
>  >
>  > There are no real rules for Mauve. Mauve is organized in an
>  > anarchic way: Everybody may nearly do everything.
>
> Uh, Michael, you're being unreasonable.  Everybody may *not* do
> nearly everything: changes require consensus.  This is not the Wild
> West, and we are not cowboys.
>
> A simple rule of thumb is "don't do things wildly diffferent from the
> way they're done already".  This covers change logs, etc.
>
> Of course tests that fail are OK, as long as they are correct. 
> That's the whole point of having a test suite, surely.

Hmm, that was what I meant, just expressed myself wrongly. Sigh.


Michael.