Re: [patch] SimpleTimeZone take 2

[Michael Koch <konqueror at gmx dot de>]

Am Freitag, 7. Mai 2004 15:30 schrieb Jerry Quinn:
> Michael Koch writes:
>  > Does the mauve test breaky compilation of mauve ? If yes we can
>  > exclude this test in mauve-libgcj file. Its always good to have
>  > the tests in mauve.
>
> It compiles fine.  But the test has failures since the library isn't
> correct.  I'm asking because usually tests don't get checked into the
> gcc testsuite while gcc is still broken.
>
> Maybe someone :-) should write a page describing checkin rules for
> mauve, such as gcc-style changelog, make sure mauve compiles, tests
> that fail are ok, etc...

There are no real rules for Mauve. Mauve is organized in an anarchic 
way: Everybody may nearly do everything.

> Hmm, insisting that a test doesn't fail is hard since it matters
> which VM and library is being used.  As far as compilation goes, is
> it OK to say as long as gcj mainline can compile the test, it can go
> in?

It can go in. The VMs that have not yet merged the new code (a.k.a. it 
doenst compile) can exclude the tests in their KEYS files. Failing 
tests are good as they show a deficit in a particalur VM.

BTW: I'm going to merge your patches to GNU classpath now.


Michael