This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: gnu.java.net.PlainDatagramSocketImpl
- From: Bryce McKinlay <mckinlay at redhat dot com>
- To: Michael Koch <konqueror at gmx dot de>, java-patches at gcc dot gnu dot org
- Date: Mon, 12 Apr 2004 14:57:53 -0400
- Subject: Re: Patch: gnu.java.net.PlainDatagramSocketImpl
- References: <200403111742.01673.konqueror@gmx.de>
Michael Koch wrote:
I just looked into merging gnu.java.net.PlainDatagramSocketImpl more
with classpath. I dont if there are better ways in CNI then this.
Any comments ? Okay for trunk ?
+ /**
+ * Lock object to serialize threads wanting to receive
+ */
+ private final Object RECEIVE_LOCK = new Object();
+
+ /**
+ * Lock object to serialize threads wanting to send
+ */
+ private final Object SEND_LOCK = new Object();
+
Hi Michael,
Are these locks really neccessary? Obviously they are a bad idea from a
performance perspective, and our implementations of send() and recieve()
shouldn't have any concurrency problems that need to be worked around
with a lock. So, I vote to remove these, unless there is something else
I'm missing?
Regards
Bryce.