This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: EmbeddedWindow additions
- From: Michael Koch <konqueror at gmx dot de>
- To: Thomas Fitzsimmons <fitzsim at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Mon, 5 Jan 2004 18:14:55 +0100
- Subject: Re: Patch: EmbeddedWindow additions
- References: <1073166757.26022.33.camel@localhost.localdomain>
On Sat, Jan 03, 2004 at 04:52:37PM -0500, Thomas Fitzsimmons wrote:
> Hello,
>
> This patch adds methods to EmbeddedWindow and its peer classes to allow
> an embedded window to be constructed before the handle to its embedding
> window is available. The patch also changes handles' representation
> from int to long, and fixes handling of GtkPlug Configure events.
>
> OK to commit?
>
> Tom
>
> 2004-01-03 Thomas Fitzsimmons <fitzsim@redhat.com>
>
> * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
> (pre_event_handler): Set all insets to 0 when a Configure event
> is received for a GtkPlug.
> * gnu/java/awt/EmbeddedWindow.java (window_id): Rename handle.
> Make handle long, not int.
> (EmbeddedWindow()): New constructor.
> (EmbeddedWindow(int)): Rename window_id to handle. Make handle
> long, not int.
> (setHandle): New method.
> (getHandle): Return long, not int.
> * gnu/java/awt/peer/EmbeddedWindowPeer.java (embed): New method
> declaration.
> * gnu/java/awt/peer/gtk/GtkEmbeddedWindowPeer.java,
> jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c:
> (create(long)): Take long parameter, not int. Cast gtk_plug_new
> argument to GdkNativeWindow.
> (construct): New method.
> (embed): New method.
This looks good to me. If Tom Tromey agrees, this can go in.
Michael