Re: [PATCH] [POSIX]: SocketTimeoutException for PlainDatagramSocketImpl + Minor Case Changes

[Michael Koch <konqueror at gmx dot de>]

On Thu, Dec 11, 2003 at 11:21:46PM -0600, Mohan Embar wrote:
> Hi Michael,
> 
> This patch has PlainDatagramSocketImpl throw a
> SocketTimeoutException instead of an InterruptedIOException
> and has minor case changes for Plain[Datagram]SocketImpl
> to make the output of the test attached to this post:
> 
> http://gcc.gnu.org/ml/java-patches/2003-q4/msg00736.html
> 
> ...diff more cleanly between Sun JRE 1.4.1 on Linux and
> i686-pc-linux-gnu-gcj.
> 
> It does <i>not</i> attempt to change the fact that
> i686-pc-linux-gnu-gcj supports interruptible I/O
> on Plain[Datagram]Sockets whereas Sun's JRE (on
> both Linux and Win32) and i686-pc-mingw32-gcj
> do not.

> -        throw new ::java::io::InterruptedIOException ();
> +        throw new ::java::net::SocketTimeoutException
> +          (JvNewStringUTF ("PeekData timed out") );

> -        throw new ::java::io::InterruptedIOException ();
> +        throw new ::java::net::SocketTimeoutException
> +          (JvNewStringUTF ("Receive timed out") );

I wanted to do this a long time ago ...

> -          (JvNewStringUTF ("Connect timed out"));
> +          (JvNewStringUTF ("connect timed out"));

Why are you changing this to lower case when you change all other to
upper case ?

With this little nit I'm okay with the patch.


Michael