This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] [MinGW]: Reset/Ignore Thread Interruption for Plain[Datagram]SocketImpl
- From: Michael Koch <konqueror at gmx dot de>
- To: Mohan Embar <gnustuff at thisiscool dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Mon, 15 Dec 2003 15:41:03 +0100
- Subject: Re: [PATCH] [MinGW]: Reset/Ignore Thread Interruption for Plain[Datagram]SocketImpl
- References: <XRRNILGTOJDUPSMGC9IGB1ZUSHBLF.3fd943dd@p733>
On Thu, Dec 11, 2003 at 10:28:13PM -0600, Mohan Embar wrote:
> Hi People,
>
> Operations on Plain[Datagram]Socket aren't
> interruptible under Sun's JRE; this patch simply
> resets and ignores the thread's interrupted
> flag after such operations. With this patch,
> I get an almost-perfect diff with the attached test
> between Sun's JRE 1.4.2 and gcj on Win32.
>
> -- Mohan
> http://www.thisiscool.com/
> http://www.animalsong.org/
>
> ChangeLog
> 2003-12-11 Mohan Embar <gnustuff@thisiscool.com>
>
> * gnu/java/net/natPlainDatagramSocketImplWin32.cc:
> Removed unused InterruptedIOException.h include.
> * gnu/java/net/natPlainSocketImplWin32.cc
> (connect): Reset and ignore our thread's interrupted
> flag instead of testing and throwing an InterruptedIOException
> if set.
> (accept): Likewise + changed case of SocketTimeoutException
> text.
> (write): Likewise (for both overloads).
> (doRead): Likewise.
I dont know enough about the threading stuff. I would like if Tom or
Bryce or Andrew can approve such type of changes. The other (case
changing) things are okay.
Michael