This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: java.net.InetAddress


On Nov 29, 2003, at 5:14 AM, Mohan Embar wrote:

I did a search for "::native" and "::impl" and I think impl is more
common. I thought native methods starting with "native" were more
common then they really are. (I only found java.lang.Runtime.nativeGetLibname
and gnu.java.nio.PipeImpl.nativeInit - hmm, who wrote that one? :) )


FWIW, I think implLookup is fine.

Just a nit, but I think "lookupImpl" is better. It makes more sense to read (in English), and has the advantage that "lookup" will appear alongside "lookupImpl" in alphabetically sorted method lists. I believe it is also more consistent with names we've used elsewhere in libgcj.


Regards

Bryce.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]