This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: image loading fixes

>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> Are the attached changes to Component.java ok?  If so, I'll check them
Tom> in along with the rest of the patch.

Looks great, just a couple little nit...

Tom> +  transient private static boolean incrementalDraw;

Should be "private static transient", I think.  The canonical
ordering is defined by Modifier.toString().

Tom> +    if ((flags & (FRAMEBITS|ALLBITS)) != 0)

You need spaces around the "|".  There are a few instances of this.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]