This is the mail archive of the
mailing list for the Java project.
Re: Patch: image loading fixes
- From: Tom Tromey <tromey at redhat dot com>
- To: Thomas Fitzsimmons <fitzsim at redhat dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, classpath at gnu dot org
- Date: 07 Nov 2003 13:00:33 -0700
- Subject: Re: Patch: image loading fixes
- References: <email@example.com>
- Reply-to: tromey at redhat dot com
>>>>> "Tom" == Thomas Fitzsimmons <firstname.lastname@example.org> writes:
Tom> This patch fixes various problems related to image loading. It also
Tom> implements Component.imageUpdate, GtkToolkit.prepareImage and the
Tom> byte-array GtkToolkit.createImage method.
Tom> - // FIXME - gcj local: GdkPixbufDecoder doesn't work.
Tom> - // return new GtkImage (new GdkPixbufDecoder (filename), null);
Tom> - return null;
Tom> + return new GtkImage (new GdkPixbufDecoder (filename), null);
I don't remember why I commented out this code in libgcj, other than
what the comment says. I assume it is ok to enable now?
Tom> + boolean incrementalDraw = Boolean.getBoolean ("awt.image.incrementalDraw");
Tom> + Long redrawRate = Long.getLong ("awt.image.redrawrate");
Should these be computed once, at class init time?
Or do we want to recompute them each time this method is called?
Also, I forget where and how we're documenting properties we
recognize. I know this has come up before though. These two should
at least be mentioned in the javadoc for the method.