Re: Mohan's Outstanding Patches

[Mohan Embar <gnustuff at thisiscool dot com>]

Hi Tom,

Concerning this:

http://gcc.gnu.org/ml/java-patches/2003-q3/msg00434.html

...you said here:

http://gcc.gnu.org/ml/java-patches/2003-q3/msg00202.html

>I like JStringToCString, but let's (1) put it somewhere less
>win32-specific, and (2) rename it.  Also it doesn't need to be in its
>own namespace.  Just adding this class, without using it, would be a
>good candidate for a separate patch.  BTW you don't need the
>heapAllocated_ field; you can just check `if (buf_ != stackbuf_)'.

>For the jvwin32 namespace, it is more typical for us to use _Jv_ as a
>prefix.  Please do that.

I made these changes, and as you know, checked in the hotly-debated
_Jv_TempUTFString patch and refactored my cleanup/networking patch.

You also said:

>I skimmed quickly through the rest of the changes.  It all looks
>pretty reasonable to me.  It also looks Win32-specific, so I won't be
>doing a deeper review.

Given that the refactoring I did for my cleanup/networking patch
(JStringToCString + no namespace + moving a header file to win32.h)
is pretty trivial, I am not clear on whether your saying that the first version
was pretty reasonable and that you wouldn't be doing a deeper review
consititutes check-in approval for the slightly-altered patch or not.
Although I don't want to waste your time, I'm still new to this whole
check-in thing and don't want to overstep my bounds, so I am choosing
to err on the conservative side and not check-in my slightly-altered patch
until you give me another thumbs-up.

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/