Re: Patches Needed for MingW 3.4

[Mohan Embar <gnustuff at thisiscool dot com>]

Hi Tom,

>Mohan> http://gcc.gnu.org/ml/java-patches/2003-q3/msg00064.html (Win32 cleanup + net stuff)
>
>Wow, big patch.

Thank you for taking the time to look at this.

>In general it is way more convenient to have the reformatting in a
>separate patch, but this time it didn't matter much.

Reformatting in a separate patch.... (*Light bulb goes on*.)
That's a smart idea. I've always wondered what the proper
way of doing this would be. Duly noted.

>I like JStringToCString, but let's (1) put it somewhere less
>win32-specific, and (2) rename it....

Any concrete suggestions for (1) and (2)? If not, I'll pick them.
Another question: is the buffer size of 500 acceptable for
all platforms if we "promote" this out of Win32? Also for
embedded targets? I was hesitating about this.

>Also it doesn't need to be in its own namespace. Just adding
>this class, without using it, would be a good candidate for a
>separate patch....

Again, duly noted. I'll submit a separate patch for this and redo
my monster patch. Too bad it's too late to undo the formatting
changes out of my big one.

>BTW you don't need the heapAllocated_ field; you can just
>check `if (buf_ != stackbuf_)'.

Pretty clever.

>For the jvwin32 namespace, it is more typical for us to use _Jv_ as a
>prefix.  Please do that.

Okay.

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/