Re: Patches Needed for MingW 3.4

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:

Mohan> http://gcc.gnu.org/ml/java-patches/2003-q3/msg00064.html (Win32 cleanup + net stuff)

Wow, big patch.

In general it is way more convenient to have the reformatting in a
separate patch, but this time it didn't matter much.

I like JStringToCString, but let's (1) put it somewhere less
win32-specific, and (2) rename it.  Also it doesn't need to be in its
own namespace.  Just adding this class, without using it, would be a
good candidate for a separate patch.  BTW you don't need the
heapAllocated_ field; you can just check `if (buf_ != stackbuf_)'.

For the jvwin32 namespace, it is more typical for us to use _Jv_ as a
prefix.  Please do that.

I skimmed quickly through the rest of the changes.  It all looks
pretty reasonable to me.  It also looks Win32-specific, so I won't be
doing a deeper review.

Tom