This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: remove unreachable finally blocks


ecj claims that unreachable finally blocks are errors.  I 
suppose it must be correct, although I haven't filed a gcj bug yet.

Is this patch OK?  It is required to build libgcj with ecj.


2003-07-19  Anthony Green  <green@redhat.com>

	* gnu/awt/xlib/XEventLoop.java (postNextEvent): Remove unreachable
	handler.
	* gnu/gcj/runtime/NameFinder.java (NameFinder): Ditto.


Index: gnu/awt/xlib/XEventLoop.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/awt/xlib/XEventLoop.java,v
retrieving revision 1.1
diff -u -2 -r1.1 XEventLoop.java
--- gnu/awt/xlib/XEventLoop.java	22 Oct 2000 17:46:09 -0000	1.1
+++ gnu/awt/xlib/XEventLoop.java	20 Jul 2003 01:19:23 -0000
@@ -49,15 +49,6 @@
   void postNextEvent()
   {
-    try
-      {
-	AWTEvent evt = getNextEvent();
-	queue.postEvent(evt);
-	
-      }
-    catch (InterruptedException ie)
-      {
-	// FIXME: what now?
-	System.err.println(ie);
-      }
+    AWTEvent evt = getNextEvent();
+    queue.postEvent(evt);
   }
     
Index: gnu/gcj/runtime/NameFinder.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/gcj/runtime/NameFinder.java,v
retrieving revision 1.5
diff -u -2 -r1.5 NameFinder.java
--- gnu/gcj/runtime/NameFinder.java	10 Mar 2003 19:45:30 -0000	1.5
+++ gnu/gcj/runtime/NameFinder.java	20 Jul 2003 01:19:23 -0000
@@ -155,16 +155,8 @@
 	if (addr2line != null)
 	  {
-	    try
-	      {
-		addr2lineIn = new BufferedReader
-			(new InputStreamReader(addr2line.getInputStream()));
-		addr2lineOut = new BufferedWriter
-			(new OutputStreamWriter(addr2line.getOutputStream()));
-	      }
-	    catch (IOException ioe)
-	      {  
-		addr2line.destroy();
-		addr2line = null;
-	      }
+	    addr2lineIn = new BufferedReader
+	      (new InputStreamReader(addr2line.getInputStream()));
+	    addr2lineOut = new BufferedWriter
+	      (new OutputStreamWriter(addr2line.getOutputStream()));
 	  }
       }

AG

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]