This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: add ActionEvent and TextEvent handling to TextComponentpeers
On Sat, 2003-07-05 at 01:20, Tom Tromey wrote:
> Tom> I think it is best to use the more general approach, where possible,
> Tom> because it can potentially reduce the amount of native code, and make
> Tom> the native code that remains more "object-oriented."
>
> Thanks for looking into this. Your analysis is great.
>
> Tom> Yes, I should have mentioned this; the setEditable and setCaretPosition
> Tom> already have working native implementations. It's just that they were
> Tom> being overridden by non-working Java implementations, for whatever
> Tom> reason.
>
> It may be my fault. I'm guessing I made this change and then forgot
> to remove the native methods. Not sure though.
>
> With the indentation fixlets the patch is fine to check in. I can put
> it in Classpath if you want; just send me the updated patch (privately
> is fine).
>
Patch checked in with requested fixes.
Tom
--
Thomas Fitzsimmons <fitzsim@redhat.com>