This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: add ActionEvent and TextEvent handling to TextComponent peers


Tom> I think it is best to use the more general approach, where possible,
Tom> because it can potentially reduce the amount of native code, and make
Tom> the native code that remains more "object-oriented."

Thanks for looking into this.  Your analysis is great.

Tom> Yes, I should have mentioned this; the setEditable and setCaretPosition
Tom> already have working native implementations.  It's just that they were
Tom> being overridden by non-working Java implementations, for whatever
Tom> reason.

It may be my fault.  I'm guessing I made this change and then forgot
to remove the native methods.  Not sure though.

With the indentation fixlets the patch is fine to check in.  I can put
it in Classpath if you want; just send me the updated patch (privately
is fine).

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]